feat: use old golang.org/x/crypto v0.43.0 with asm optimized sha3#5364
Draft
feat: use old golang.org/x/crypto v0.43.0 with asm optimized sha3#5364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR addresses the problem with removed asm optimized sha3 package for amd64 architecture.
Package golang.org/x/crypto removed optimized files in version 0.44.0 which leaves its version 0.43.0 the latest one with more performant legacy keccak 256 implementation:
https://cs.opensource.google/go/x/crypto/+/refs/tags/v0.43.0:sha3/
https://cs.opensource.google/go/x/crypto/+/refs/tags/v0.44.0:sha3/
Some project decided to fork the implementation such as go-ethereum ethereum/go-ethereum#33323 and filecoin https://github.com/filecoin-project/go-keccak, but in this PR, an already published golang.org/x/crypto v0.43.0 is used with the help of go.mod replace directive to avoid any possibility of compromizing the hash function in the forked code.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):